Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: #220 terms and conditions modal first time login dev portal #241

Merged
merged 4 commits into from
Feb 12, 2020
Merged

feat: #220 terms and conditions modal first time login dev portal #241

merged 4 commits into from
Feb 12, 2020

Conversation

vuhuucuong
Copy link
Contributor

Fixes #220

@github-actions github-actions bot added elements Relates to Elements components and utilities marketplace Relates to the Marketplace labels Feb 11, 2020
duong-se
duong-se approved these changes Feb 11, 2020
View reviewed changes
Copy link
Contributor

@duong-se duong-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

willmcvay
willmcvay approved these changes Feb 12, 2020
View reviewed changes
Copy link
Contributor

@willmcvay willmcvay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, happy to merge if you can get the conflicts resolved 👍

@vuhuucuong vuhuucuong force-pushed the feat/220-terms-and-conditions-modal-first-time-login-dev-portal branch from f18d79e to fa36d24 Compare February 12, 2020 08:43
@willmcvay willmcvay merged commit a62b348 into master Feb 12, 2020
@willmcvay willmcvay deleted the feat/220-terms-and-conditions-modal-first-time-login-dev-portal branch February 12, 2020 09:07
nphivu414 pushed a commit that referenced this pull request Apr 29, 2020
@trankhacvy
[CLD-587] Update submit or update app flow following back-end update (#…
8aef449 
…241)

* [CLD-587] Update submit or update app flow following back-end update

* Update show client secret

* [CLD-587] Update foundations-ts-definitions
nphivu414 pushed a commit that referenced this pull request Apr 29, 2020
@vuhuucuong
feat: #220 terms and conditions modal first time login dev portal (#241)
c924abd 
* feat: #220 terms and condition modal when dev first login dev portal

* feat: #220 update test badges

* feat: #220 update terms and conditions ui

* fix: #220 update badges
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannd4 dannd4 Awaiting requested review from dannd4

@phmngocnghia phmngocnghia Awaiting requested review from phmngocnghia

@trankhacvy trankhacvy Awaiting requested review from trankhacvy

@zlatanpham zlatanpham Awaiting requested review from zlatanpham

@duong-se duong-se Awaiting requested review from duong-se

@willmcvay willmcvay Awaiting requested review from willmcvay

Assignees

@vuhuucuong vuhuucuong

Labels
elements Relates to Elements components and utilities marketplace Relates to the Marketplace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a ‘Terms and ‘Conditions’ modal to the developer portal on first time login
3 participants
@vuhuucuong @willmcvay @duong-se